Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.13.z] Remove cli.factory dependencies from the repo (#11544) #13225

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Nov 30, 2023

Problem Statement

Automatic Cherrypick of #11544 is failed and hence raised this manual cherrypick!

Solution

Closes #13129

@jyejare jyejare changed the title Remove cli.factory dependencies from the repo (#11544) [6.13.z] Remove cli.factory dependencies from the repo (#11544) Nov 30, 2023
@jyejare jyejare added No-CherryPick PR doesnt need CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 labels Nov 30, 2023
@Gauravtalreja1
Copy link
Collaborator

@jyejare Thank you, Could you also cherrypick the changes for identified issues with the original PR?
#13196 and #13167

@jyejare
Copy link
Member Author

jyejare commented Nov 30, 2023

@Gauravtalreja1 I already fixed #13167 during first cherrypicking hence it does not need explicit cherrypick! I just cherrypicked #13196 now !

Please review !

@Gauravtalreja1 Gauravtalreja1 merged commit 4e0c9f7 into SatelliteQE:6.13.z Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants